Remove source db object from SourceWidget #967
Conversation
|
Let's merge #952 next and then this |
| if source_widget: | ||
| return self.controller.get_source(source_widget.source_uuid) | ||
| except sqlalchemy.exc.InvalidRequestError: | ||
| pass |
There was a problem hiding this comment.
pass so that we let the next sync delete the SourceWidget?
| list_item = self.item(i) | ||
| source_widget = self.itemWidget(list_item) | ||
| if source_widget and source_widget.source_uuid == source_uuid: | ||
| return source_widget |
There was a problem hiding this comment.
clarifying: under which circumstances can the source widget be in the cache but not the source list?
There was a problem hiding this comment.
I think we could rely completely on the cache. I abstracted getting the source widget here because I was thinking we didn't need both the qt list and the cache since we have to loop through all items in the qt list (SourceList) anyway. But after thinking about this more, we have future plans to modify server code so that it only returns sources that have updates, and that's when the cache will come in handy (because we won't have to loop through the entire source list anymore and update all the source widgets). Long story short: I can update this method so that there's no fall back if we try to get a source widget that hasn't been added to the cache yet (since we add items to the cache before adding them to the qt list, this currently can't happen, but, if we ever switch the order of this by accident, having a fallback would ensure that we'll be able to get the selected source widget in the list)
|
This is on hold until this PR is finished and merged: #944 |
|
marking as blocked so that we don't introduce more conflicts for #944 as @creviera mentions above |
|
Closing for now and will revisit in another sprint |
|
@creviera Do you still want to keep this PR in our near-term backlog, for consideration in another sprint? |
Description
After #964 is merged, this will need a rebase and will be ready for review.
Towards #906 and minimizing access of database objects in the GUI in order to avoid crashes. This removes the source database object from the SourceWidget and fixes #1 in #906.
The PR that removes the source object from the star will either need to be merged after this PR or if before, I'll need to do a rebase.
Test Plan
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable: