Adds more functional tests for the client #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushaldas
force-pushed
the
behind_the_north_wall_of_funcational_tests
branch
from
4f2fb7a to
a852d90
Compare
sssoleileraaa
previously approved these changes
Mar 23, 2020
| dialog = ExportDialog(self.controller, self.uuid, self.file.filename) | ||
| dialog.exec() | ||
| self.export_dialog = ExportDialog(self.controller, self.uuid, self.file.filename) | ||
| self.export_dialog.show() |
There was a problem hiding this comment.
This works fine since the dialogs make sure to not allow multiple dialogs at the same time.
This also modifies the export dialog excutation flow, by using .show() method, thus avoiding an internal eventloop from the previously used .exec_()
sssoleileraaa
force-pushed
the
behind_the_north_wall_of_funcational_tests
branch
from
9e504bc to
80cf783
Compare
sssoleileraaa
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two new functional tests, one is for downloading a file.
And the second is for export dialog.
Test Plan
make test-functionalChecklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable: