Allow for multi-threaded requests to the API. #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kushaldas
approved these changes
Nov 1, 2018
redshiftzero
force-pushed
the
multi-threading-requests
branch
from
ea28530 to
276470b
Compare
redshiftzero
approved these changes
Nov 1, 2018
There was a problem hiding this comment.
very clear implementation - thanks @ntoll! rebased to fix conflicts and approving
legoktm
pushed a commit
that referenced
this pull request
Dec 11, 2023
…s-6.2.0 use latest pip-tools and update readme
legoktm
pushed a commit
that referenced
this pull request
Dec 15, 2023
Getting ready for 0.0.10 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90.
This PR introduces the capability of having multiple API calls "in flight" at the same time. Things to note:
api_threadsdict stores the thread, APICallRunner instance and QTimer associated with each call against a unique uuid.clean_threadmethod cleans up things and removes the entry inapi_threads.call_apimethod, or in the event handlers passed into handle the possible outcomes (this seems the sensible place to do it since thecall_apimethod is "function neutral"). See the way I've done this inon_file_clickandon_file_download.