Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login UI messages per UI messages audit #903

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Conversation

eloquence
Copy link
Member

@eloquence eloquence commented Mar 10, 2020

Status

Ready for review

Description

Part of #53. Makes error messages a bit more consistent and (hopefully) friendly:

  • Always use "passphrase", not sometimes "password".
  • Use "that won't work" for form submissions that instantly fail validation, followed by the reason
  • Use "that didn't work" for form submissions that fail after being sent, followed by actionable advice (use a fresh two-factor code).

Switches the error bar to SecureQLabel as apostrophes were otherwise displayed incorrectly.

Updates the version string as previously discussed here.

Test plan

  • Verify that all errors are handled as expected per the screenshots below, including in Qubes.

Checklist

  • Tested in Qubes
  • No packaging implications

Screenshots

Click to expand

Screenshot from 2020-03-09 23-05-48
Screenshot from 2020-03-09 23-05-41
Screenshot from 2020-03-09 23-05-35
Screenshot from 2020-03-09 23-05-32
Screenshot from 2020-03-09 23-05-10

@eloquence eloquence force-pushed the string-updates branch 2 times, most recently from e897fa3 to 766bc39 Compare March 10, 2020 05:57
@eloquence eloquence changed the title Update login error messages per UI messages audit Update login UI messages per UI messages audit Mar 10, 2020
@eloquence eloquence marked this pull request as ready for review March 10, 2020 06:10
@eloquence
Copy link
Member Author

@ninavizz and I screen-shared this in Qubes (using fancy new Qubes screen-shairng setup ;-) and she has signed off on these changes. We'd like to do a bit more polish on the error bar in future, to give it more breathing room for longer messages, but that can be done post-beta or in a small follow-up PR.

@redshiftzero redshiftzero merged commit ade88d4 into master Mar 13, 2020
@redshiftzero redshiftzero deleted the string-updates branch March 13, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants