Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify threading #85

Merged
merged 8 commits into from
Oct 31, 2018
Merged

Robustify threading #85

merged 8 commits into from
Oct 31, 2018

Conversation

ntoll
Copy link
Contributor

@ntoll ntoll commented Oct 30, 2018

This is stacked on #77 and fixes #80 and #71.

Things to note:

  • The event handler taking the completed outcome, is expected to guard / check that the result is correct.
  • I've updated the existing event handlers (please check!)
  • Happy to change anything!

:-)

@redshiftzero redshiftzero self-requested a review October 30, 2018 16:00
@redshiftzero redshiftzero mentioned this pull request Oct 31, 2018
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this diff looks good 🎉 and works for me locally in non-Qubes. In Qubes, I'm able to login without issue and do other actions (namely, I can sync fine) - though I'm seeing issues related to qvm moving files into the sd-svs VM that look to be unrelated. Since this is an improvement on master, I'm going to merge this and file a followup for figuring out the remainder of the Qubes only issues

@redshiftzero redshiftzero merged commit f06d2f9 into master Oct 31, 2018
@redshiftzero redshiftzero deleted the robustify-threading branch October 31, 2018 00:29
@redshiftzero redshiftzero mentioned this pull request Nov 1, 2018
legoktm pushed a commit that referenced this pull request Dec 11, 2023
use new reproducible wheel from packaging with build
legoktm pushed a commit that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor API calls to be more robust
3 participants