no longer mark replies as failed if they time out #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
force-pushed
the
replies-that-timeout-are-no-longer-failed
branch
2 times, most recently
from
ef0a5bf to
eff9bdd
Compare
sssoleileraaa
requested review from
kushaldas and
redshiftzero
as code owners
|
This fixes the issue reported in #653, however I'm leaving it open and will add a new STR for non-timeout errors in that issue so that it is a two-part issue to solve. |
|
This is blocked until #820 is fixed so we can properly test request timeout errors along with connection errors. |
3 tasks
sssoleileraaa
force-pushed
the
replies-that-timeout-are-no-longer-failed
branch
from
eff9bdd to
51232ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #604
Towards #653
We have another draft PR (#818) that I'll be looking at today that is working to fix #653. This PR fixes the out-of-order issue for replies that time out (since we no longer mark them as failed). #818 will fix the out-of-order issue for replies that fail for some other reason.
This will go from draft->ready for review once I update tests.
Test Plan
Run through STR#1 for #653 and make sure replies are no longer out of order and that replies that time out are still shown as pending.
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable: