Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #776 fixes mkdir permission in apparmor #777

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

kushaldas
Copy link
Contributor

@kushaldas kushaldas commented Feb 5, 2020

Description

Fixes #776

Now the client can create directories under
/home/user/.securedrop-client/data/
for different sources.

Test Plan

  • Open a client and see it is downloading files/messages properly and decrypting
  • No apparmor error in /var/log/syslog.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable:

  • I have submitted a separate PR to the packaging repo
  • No update to the packaging logic (e.g., AppArmor profile) is required for these changes
  • I don't know and would appreciate guidance

Now the client can create directories under
/home/user/.securedrop-client/data/
for different sources.
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@redshiftzero redshiftzero merged commit 7bbb265 into master Feb 6, 2020
@redshiftzero redshiftzero deleted the dear_apparmor_allow_mkdir branch February 6, 2020 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppArmor prevents directory creation, causing sync failure
3 participants