Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple shim for status feedback. #65

Merged
merged 3 commits into from
Oct 24, 2018

Conversation

ntoll
Copy link
Contributor

@ntoll ntoll commented Oct 24, 2018

This PR introduces two things:

  • A QStatusBar at the bottom of the application in which text can be placed to indicate an important event.
  • A "shim" API in the logic layer called set_status which takes two arguments: a message string and (optional) duration (default = 5 seconds).

This is a temporary fix. I expect that status updates will still use the set_status method in future but we'll plug that into whatever the final status indication solution may be.

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@redshiftzero redshiftzero merged commit 810b404 into freedomofpress:master Oct 24, 2018
@redshiftzero redshiftzero mentioned this pull request Oct 25, 2018
legoktm pushed a commit that referenced this pull request Dec 11, 2023
Removes container's upstream virtualenv
legoktm pushed a commit that referenced this pull request Dec 11, 2023
legoktm pushed a commit that referenced this pull request Dec 15, 2023
updates how we call pipenv to ensure depenendencies aren't updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants