converted tests to use pytest-mock #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heartsucker
force-pushed
the
pytest-mock
branch
from
c164062 to
0f7a2e0
Compare
redshiftzero
approved these changes
Nov 26, 2018
| ms.api.download_reply = mocker.MagicMock(return_value=(1234, "/home/user/downloads/foo")) | ||
|
|
||
| # check that it runs without raising exceptions | ||
| ms.run(False) |
There was a problem hiding this comment.
right now these gpg tests are only checking that no exceptions occur, but we really should be asserting that e.g. the mock of securedrop_client.message_sync.storage.mark_file_as_downloaded was called once with the expected args (not blocking this PR on that, just a flag for when you pick up the gpg wrapper ticket which I know you're working on next)
legoktm
pushed a commit
that referenced
this pull request
Dec 11, 2023
build-requirements: update for production beta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #42
pytest-mockis nice because of some of the guarantees of clean up between functions. It also has some helpers for use in loops. This also removes the constant use ofwithblocks (which I think makes code more readable because with a 79 char limit, I want as much real estate as possible for code).