Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci + test: buster, python 3.7 support #568

Merged
merged 2 commits into from
Oct 18, 2019

Conversation

redshiftzero
Copy link
Contributor

@redshiftzero redshiftzero commented Oct 16, 2019

Description

towards #527

add buster test job (build job we can't add until we update our pip mirror) and gets tests passing on buster / python 3.7.

the one application change here is to ensure that calling safe_mkdir(sdc_home) directly actually creates sdc_home - previously it would just return without creating the directory.

Testing

  1. Make a python 3.7 virtualenv
  2. Ensure you can start the application
  3. New CI job should also pass

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sssoleileraaa sssoleileraaa merged commit 31bb946 into freedomofpress:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants