Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs around upgrading dependencies #536

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented Aug 15, 2019

Description

Upgrade our PyQt dev dependency and update readme docs about updating dependencies.

Even though we're no longer seeing #273 occur, we know that the upstream qt bug was fixed in a version of Qt later than the one we've been using.

Resolves #273

@sssoleileraaa
Copy link
Contributor Author

In order to get around a pip-compile error, I switched from using pip-19.2.2 to pip-18.0

This is the error, in case others run into it:

AttributeError: 'Values' object has no attribute 'process_dependency_links'
Makefile:67: recipe for target 'update-pip-requirements' failed
make: *** [update-pip-requirements] Error 1

@kushaldas
Copy link
Contributor

Debian Buster does not have that version of Qt/PyQt :(

Get:1 https://mirror.0x.sg/debian buster/main amd64 python3-pyqt5 amd64 5.11.3+dfsg-1+b3

@redshiftzero
Copy link
Contributor

hmm good catch, the most recent version buster has is 5.11.3 which does not have the fix https://packages.debian.org/buster/python3-pyqt5 (fix first available in
5.12.4)

@sssoleileraaa sssoleileraaa changed the title upgrade from pyqt 5.10.1 to 5.13.0 update docs around upgrading dependencies Aug 15, 2019
@sssoleileraaa
Copy link
Contributor Author

Okay, so I repurposed the PR to remove the upgrade but keep the docs changes. Ready for review!

@sssoleileraaa sssoleileraaa force-pushed the upgrade-to-latest-pyqt branch from 357b58a to 688bff1 Compare August 15, 2019 22:53
@eloquence eloquence changed the title update docs around upgrading dependencies Update docs around upgrading dependencies Aug 15, 2019
@redshiftzero redshiftzero merged commit 22af888 into master Aug 19, 2019
@redshiftzero redshiftzero deleted the upgrade-to-latest-pyqt branch August 19, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QTBUG-69204 - Upstream Qt stylesheet bug causes segmentation faults
4 participants