Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #478 creates QApplication for QPixmap #479

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Conversation

kushaldas
Copy link
Contributor

Without a QApplication the code will core dump as menioned
in the issue.

Description

Fixes #478

Test Plan

make test TESTS=tests/test_resources.py

Checklist

Not required.

@kushaldas
Copy link
Contributor Author

While testing this on CI, found more issue.

$ python
Python 3.5.7 (default, Jul 13 2019, 15:29:43) 
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import securedrop_client.resources
>>> from PyQt5.QtGui import QIcon, QPixmap
>>> from PyQt5.QtSvg import QSvgWidget
>>> from PyQt5.QtWidgets import QApplication
>>> 
>>> 
>>> app = QApplication([])
This application failed to start because it could not find or load the Qt platform plugin "xcb"
in "".

Available platform plugins are: eglfs, linuxfb, minimal, minimalegl, offscreen, vnc, xcb.

Reinstalling the application may fix this problem.
Aborted (core dumped)

Without a QApplication the code will core dump as menioned
in the issue.
@kushaldas kushaldas requested a review from emkll July 17, 2019 13:51
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kushaldas this seems to resolve CI issues.

Built a deb locally and installed it in sd-svs, everything seems to work as expected

@redshiftzero redshiftzero merged commit 271cd55 into master Jul 17, 2019
@redshiftzero redshiftzero deleted the fix_core_dump branch July 17, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: core dump errors
3 participants