Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unpin bandit #439

Merged
merged 2 commits into from
Jun 26, 2019
Merged

unpin bandit #439

merged 2 commits into from
Jun 26, 2019

Conversation

redshiftzero
Copy link
Contributor

Description

Fixes #429

Test Plan

  • Run make bandit locally, all should pass
  • Check 'Files skipped (0):' in CI test job output for Run static analysis on source code to find security issues step

@redshiftzero redshiftzero requested a review from emkll June 26, 2019 19:31
sssoleileraaa
sssoleileraaa approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix works

thx for reminding me that we can now use virtualenv instead of pipenv (had to switch in order to test this)

@redshiftzero redshiftzero merged commit 8bed8cb into master Jun 26, 2019
@redshiftzero redshiftzero deleted the bandit-fix branch June 26, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sssoleileraaa sssoleileraaa sssoleileraaa approved these changes

@emkll emkll Awaiting requested review from emkll

@heartsucker heartsucker Awaiting requested review from heartsucker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test and unpin Bandit
3 participants
@redshiftzero @sssoleileraaa @emkll