Version 0.0.8 #428
Merged
Version 0.0.8 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the CI failure here looks like PyCQA/bandit#488 |
|
ah yeah, new bandit release (1.6.1) with a fix for the above bug that doesn't appear to be working here... |
|
@creviera want to append a commit pinning to the version that doesn't suffer from this bug, e.g.: diff --git a/Makefile b/Makefile
index 6635db9..cf0ab18 100644
--- a/Makefile
+++ b/Makefile
@@ -57,7 +57,7 @@ safety: ## Runs `safety check` to check python dependencies for vulnerabilities
.PHONY: bandit
bandit: ## Run bandit with medium level excluding test-related folders
pip install --upgrade pip && \
- pip install --upgrade bandit!=1.6.0 && \
+ pip install --upgrade bandit==1.5.1 && \
bandit -ll --recursive . --exclude tests,.venv
.PHONY: checkthen we can file an issue for unpinning as followup |
sssoleileraaa
force-pushed
the
release/0.0.8
branch
from
26ad606 to
108a74e
Compare
Closed
sssoleileraaa
force-pushed
the
release/0.0.8
branch
from
108a74e to
6c198b7
Compare
|
I tested building the debian package in qubes and was able to log into the client and see decrypted messages. |
|
Looks good - can you push a 0.0.8 tag on f526a12 (flagging the commit here since the tag should be on this specific commit)? |
|
confirming successful build on these changes: https://circleci.com/gh/freedomofpress/securedrop-debian-packaging/25 |
This was referenced Jun 17, 2019
Release securedrop-proxy 0.1.4 and securedrop-client 0.0.8
freedomofpress/securedrop-workstation#268
Closed
Merged
eloquence
added a commit
to freedomofpress/securedrop
that referenced
this pull request
Jun 18, 2019
See discussion in the client repo where we also encountered this issue: freedomofpress/securedrop-client#428
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to version 0.0.8
This has the pipenv -> pip-tools change, which will unblock freedomofpress/securedrop-builder#44 and freedomofpress/securedrop-builder#48