Issue 389 sync #405
Merged
Issue 389 sync #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
force-pushed
the
issue-389-sync
branch
from
33ad9b3 to
48076ee
Compare
redshiftzero
reviewed
Jun 6, 2019
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class DownloadSubmissionJob(ApiJob): | ||
| class MessageDownloadJob(ApiJob): |
There was a problem hiding this comment.
is the plan still to inherit from a new common object to reduce code duplication with FileDownloadJob?
There was a problem hiding this comment.
Yup! That's the plan: MessageDownloadJob, FileDownloadJob, and ReplyDownloadJob will all inherit from a DownloadJob class. I tried to keep the _decrypt_file method generic enough so that we can move it into DownloadJob. There should be a follow-up PR for this.
I just wanted to keep code changes small here since deleting the message_sync thread felt like a big change.
| class DownloadSubmissionJob(ApiJob): | ||
| class MessageDownloadJob(ApiJob): | ||
|
|
||
| CHUNK_SIZE = 4096 |
| job.success_signal.connect(self.on_message_download_success, type=Qt.QueuedConnection) | ||
| job.failure_signal.connect(self.on_message_download_failure, type=Qt.QueuedConnection) | ||
|
|
||
| self.api_job_queue.enqueue(job) |
sssoleileraaa
force-pushed
the
issue-389-sync
branch
from
48076ee to
9805dc8
Compare
added 8 commits
June 6, 2019 15:05
sssoleileraaa
force-pushed
the
issue-389-sync
branch
from
9805dc8 to
adeb6dc
Compare
redshiftzero
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #389
MessageDownloadJobTest Plan