Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: pure refactor/reorganize to separate *Queue and APIJob objects #398

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

redshiftzero
Copy link
Contributor

Description

Towards #390

We are going to be adding quite a few more API jobs (even without
considering any additional functionality that might be added to the
application). Let's break the logic up a bit (organizing the api jobs and removing them from queue.py) so that it's easier to move around the codebase.

I'm putting this in a separate commit because we're starting to work on #389 and #390 in parallel so let's merge this first since the diff is large

We are going to be adding quite a few more API jobs (even without
considering any additional functionality that might be added to the
application). Let's separate the logic out a bit so that it's easier
to move around the codebase.
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sssoleileraaa sssoleileraaa merged commit 6125793 into master Jun 4, 2019
@sssoleileraaa sssoleileraaa deleted the pure-refactor-before-more-queue branch June 4, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants