polish refresh #373
Merged
polish refresh #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I click the refresh icon, it appears to get smaller than the unclicked version. Is this the expected behavior? |
|
@heartsucker - nina pointed that out to me today also! Here are the things we agreed on that I need to update in the PR:
|
sssoleileraaa
force-pushed
the
refresh-polish
branch
2 times, most recently
from
1cba94a to
52f3138
Compare
sssoleileraaa
force-pushed
the
refresh-polish
branch
from
52f3138 to
46b12a9
Compare
|
[after out of band discussion, we're holding off on merging this one until we can run it past @ninavizz in the UX review] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #310
Small change to make the three refresh-related icons all the same size. The click area around the button isn't as large as it used to be now.
Last refreshis nowLast Refresh.