Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused sdc_home #344

Merged
merged 1 commit into from
May 1, 2019
Merged

remove unused sdc_home #344

merged 1 commit into from
May 1, 2019

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented May 1, 2019 •
edited
Loading

Description

Just a quick refactor where we were passing sdc_home to Window and then not doing anything with it. We also don't need to pass the is_authenticated to show_conversation_for because we already have a reference to the Controller.

Test

Client should behave exactly the same as before. Automated and manual tests should pass.

redshiftzero
redshiftzero approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (also in the spirit of separation of concerns, good that the GUI layer doesn't access sdc_home)

@redshiftzero
Copy link
Contributor

[btw I did run through the standard test plan, all working as expected]

@redshiftzero redshiftzero merged commit ac6c0f9 into master May 1, 2019
@redshiftzero redshiftzero deleted the unused_sdc_home branch May 1, 2019 20:56
@eloquence eloquence mentioned this pull request Dec 11, 2019
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redshiftzero redshiftzero redshiftzero approved these changes

@heartsucker heartsucker Awaiting requested review from heartsucker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sssoleileraaa @redshiftzero