Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update securedrop-sdk to 0.0.8 #338

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Update securedrop-sdk to 0.0.8 #338

merged 1 commit into from
Apr 30, 2019

Conversation

rmol
Copy link
Contributor

@rmol rmol commented Apr 29, 2019

The SDK update means logic.APIController.api.token is now a str, not a dict, and the journalist UUID is stored separately in logic.APIController.token.token_journalist_uuid.

Tests/mocks updated accordingly.

Fixes #292.

requirements.txt Outdated
@@ -9,7 +9,7 @@ pathlib2==2.3.2 --hash=sha256:8e276e2bf50a9a06c36e20f03b050e59b63dfe0678e3716433
python-dateutil==2.7.5 --hash=sha256:56f285e7fad54cde3e31dc68a31a861543bfee5ada9278da8e85ec20a8f72912
python-editor==1.0.3 --hash=sha256:44fc57a6db6e04c7922c37a04d0a86d0024a4f0f06245b6c57638cb322176202
requests==2.20.0 --hash=sha256:2a539dd6af40a611f3b8eb3f99d3567781352ece1698b2fab42bf4c2218705b5
securedrop-sdk==0.0.4 --hash=sha256:50a6b980e2fcdbc78b00fa7b978cc91350364c94497f730b1c01f5ad446866c7
securedrop-sdk==0.0.8 --hash=sha256:eca697da2520b568a4600b11c3ab818f5855e0ce13f88495d756a894f142f2a1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be updated during the release process, and will contain the hash of the wheel on FPF's pip mirror, see explanatory gif here:

https://raw.githubusercontent.com/freedomofpress/securedrop-debian-packaging/b4c640cb69b48f190b07fa803a5100bc4d8e8511/images/securedrop-pip-mirror.gif

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Removed.

The SDK update means logic.APIController.api.token is now a str, not a
dict, and the journalist UUID is stored separately in
logic.APIController.token.token_journalist_uuid.

Tests/mocks updated accordingly.
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[updated dependency is FPF controlled]

@redshiftzero redshiftzero merged commit b7657e9 into freedomofpress:master Apr 30, 2019
@rmol
Copy link
Contributor Author

rmol commented May 6, 2019

I've confirmed that the SHA256 of the securedrop-sdk 0.0.8 tarball on PyPI matches that on my development machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PyYAML dependency
3 participants