Restructure the layout of SourceWidget #330
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #280
This restructures
SourceWidget
to show timestamp, star, delete, and attachment icons in preparation for:We have a separate issue for styling and polishing, which will fix off-by-one pixels issues, etc.
Summary of Changes
timestamp
row. The change here is a proposal for the team, leaning on @ninavizz and @eloquence for feedback. I noticed when testing the changes that our "x days ago" humanized timestamp is cut off by the message preview. I suggest that, for now, we lower the timestamp so that we won't have this problem, and create a new Issue if we want a different solution. I could also place the timestamp somewhere else in this PR if we find another location that makes sense. See images:Trying to match Zeplin:
My proposal until further discussion about how to handle the timestamp getting cut off:
Test
Known issues