-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync logic #27
Sync logic #27
Conversation
Dammit... the build has failed because |
@ntoll try this::
|
Thanks @kushaldas -- CI is working now. :-) |
hey @ntoll gave this a look over today, super clear implementation, this is exactly what we're lookin for! let's add the replies to this, and one note on that to bear in mind (apologies if you thought about/realized this already): as journalist users are observed in replies we want to add the journalist username/UUID to the database (and usernames can change so we need to update them too). |
@redshiftzero OK... added reply and user handling. |
not adding a separate migration because we're going to squash all of these prior to initial release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
securedrop_client/storage.py
Outdated
@@ -21,7 +21,7 @@ | |||
""" | |||
import logging | |||
from dateutil.parser import parse | |||
from securedrop_client.models import Source, Submission | |||
from securedrop_client.models import Source, Submission, Reply, User |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I foresee confusion between the sqlalchemy models and the SDK objects (not introduced in this PR, just a thought). Maybe we can change the names of the sqlalchemy objects to SourceDatabaseObject
or something similar for the sake of being explicit (I don't love that name but you get the idea)
Adds new sha256sums for PyYAML 5.1 and new release
minor fixes to stabilize the dev env
This PR contains a solution for #5. However, it's a work in progress and given that I'm "new" to this project I'm keen to get feedback about style/approach.
This is stacked on PR #23.
Questions: