Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear old items in conversation view on refresh #242

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Clear old items in conversation view on refresh #242

merged 1 commit into from
Feb 13, 2019

Conversation

sssoleileraaa
Copy link
Contributor

Fixes #226 and [Conversation Reordering] issue noted in #240

STR

  1. start client
  2. refresh
  3. resize window (should no longer see bubble layering issue)
  4. send message from source
  5. refresh, resize (should see no bubble layering issues)

@sssoleileraaa sssoleileraaa changed the title clear old items in conversation window on refresh [WIP] clear old items in conversation window on refresh Feb 7, 2019
@sssoleileraaa sssoleileraaa changed the title [WIP] clear old items in conversation window on refresh [WIP] clear old items in conversation view on refresh Feb 7, 2019
heartsucker
heartsucker approved these changes Feb 10, 2019
View reviewed changes
Copy link
Contributor

@heartsucker heartsucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, but approving :D

@sssoleileraaa sssoleileraaa changed the title [WIP] clear old items in conversation view on refresh Clear old items in conversation view on refresh Feb 13, 2019
@redshiftzero
Copy link
Contributor

thanks @creviera and @heartsucker for review!

@redshiftzero redshiftzero merged commit 3414250 into freedomofpress:master Feb 13, 2019
@sssoleileraaa sssoleileraaa deleted the rerender-fix branch February 13, 2019 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heartsucker heartsucker heartsucker approved these changes

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sssoleileraaa @redshiftzero @heartsucker