[0.14.0] Truncate source list displayed in delete dialog #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmonkeykstop
force-pushed
the
2284-truncated-source-list
branch
from
41bd700 to
4fd8dcb
Compare
deeplow
approved these changes
Nov 14, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
Fixes #2284
Sets a limit of 32 sources to be displayed in the deletion dialog before the list is truncated to avoid text overruns that push the safety warnings out of the viewport.
... plus N additional sourceswhere N = len(sources -30)Test Plan
set up an SD instance (dev easiest) with ~150 sources.
start the client using that instance
select 1 source, click DELETE SOURCES and verify that only the source is shown. Click "YES.." and verify that the source is deleted.
select 32 sources, click DELETE SOURCES and verify that the sources are all shown. Click "YES.." and verify that the sources are deleted.
select 33 sources, click DELETE SOURCES and verify that the first 30 sources are shown followed by a message
plus 3 additional sources. Click "YES.." and verify that the sources are deleted.-[ ] select all remaining sources, click DELETE SOURCES and verify that the first 30 sources are shown followed by a message
plus N additional sources, where N+30 equals the total number of sources shown in theYES,...button . Click "YES.." and verify that all sources are deleted.