Handle get_db_object() failures as DownloadException #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our error handling expects that failures from DownloadJobs raise DownloadExceptions, so let's do that. This is roughly the same concept as a9f0590, just in a different part of the code. The exception handling has to exist in each class (instead of `one_or_none()`) because we need to know the corresponding type to pass to DownloadException. Fixes #2274.
legoktm
force-pushed
the
optional-get_db_object
branch
from
2b3c229 to
12f75f0
Compare
deeplow
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
Our error handling expects that failures from DownloadJobs raise DownloadExceptions, so let's do that.
This is roughly the same concept as a9f0590, just in a different part of the code. The exception handling has to exist in each class (instead of
one_or_none()) because we need to know the corresponding type to pass to DownloadException.Fixes #2274.
Test Plan
on_reply_download_failure()assumes exceptions have auuidattribute #2274 and confirm it's failingon_reply_download_failure()assumes exceptions have auuidattribute #2274 and it should passChecklist