Move Top Pane to Bottom #2230
Merged
Move Top Pane to Bottom #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocodes
force-pushed
the
top-pane-to-the-bottom
branch
from
4d2aab1 to
c983e74
Compare
|
(initial refactor PR; separate PR for adding the batch action toolbar across the top coming presently) |
This was referenced Sep 17, 2024
See discussion at <#2160 (comment)>. Refs #2160.
legoktm
previously approved these changes
Sep 20, 2024
There was a problem hiding this comment.
It's impressive how this is functionally a 2 line change, reordering the addWidget calls, and the rest is just updating the name and tests.
So in testing it looks good, but there were a few places in test_widgets that the old TopPane name was still being used, I'm going to push an amended version with those trivial fixes in and then merge.
legoktm
force-pushed
the
top-pane-to-the-bottom
branch
from
c983e74 to
86e07a5
Compare
legoktm
approved these changes
Sep 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description
Move Status pane ("top pane") to the bottom of the app, and rename.
Towards #2160
Refs #2160 (comment)
Test Plan
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
If these changes modify the database schema, you should include a database migration. Please check as applicable:
mainand confirmed that the migration is self-contained and applies cleanlymainand would like the reviewer to do so