Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to obsolete securedrop-workstation-svs-disp package #2145

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Jul 25, 2024

Status

Ready for review

Description

The svs-disp package was made obsolete in Oct. 2020 (freedomofpress/securedrop-builder#198), and given the fresh installs for both 4.1 and 4.2 since then, there's no need to continue keeping the Provides/Conflicts/Replaces stanzas.

Test Plan

  • Visual review

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • No update to the AppArmor profile is required for these changes

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • No database schema changes are needed

The svs-disp package was made obsolete in Oct. 2020
(freedomofpress/securedrop-builder#198), and
given the fresh installs for both 4.1 and 4.2 since then, there's no
need to continue keeping the Provides/Conflicts/Replaces stanzas.
@legoktm legoktm requested a review from a team as a code owner July 25, 2024 18:32
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM based on visual review.

@zenmonkeykstop zenmonkeykstop merged commit aa403a7 into main Aug 8, 2024
58 checks passed
@zenmonkeykstop zenmonkeykstop deleted the rm-conflicts-replaces branch August 8, 2024 19:02
@legoktm legoktm added this to the 0.13.0 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants