Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove pre-commit hooks #1896

Merged
merged 1 commit into from
Mar 11, 2024
Merged

chore: remove pre-commit hooks #1896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions client/.githooks/pre-commit
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions client/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,6 @@ all: help
PYTHON := $(if $(shell bash -c "command -v python3.9"), python3.9, python3)
VERSION_CODENAME ?= bullseye

HOOKS_DIR=.githooks

.PHONY: hooks
hooks: ## Configure Git to use the hooks provided by this repository.
git config core.hooksPath "$(HOOKS_DIR)"

SEMGREP_FLAGS := --exclude "tests/" --error --strict --verbose

.PHONY: semgrep
Expand Down
4 changes: 0 additions & 4 deletions client/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ poetry install
```

* You will need Python 3.9 to run the client. If it's not the default `python3` on your installation, you can set `poetry env use python3.9`.
* You may also want to run `make hooks`, which will configure Git to use the hooks found in `.githooks/` to check certain code-quality standards on new commits in this repository. These checks are also enforced in CI.

4. Run SecureDrop Client

Expand Down Expand Up @@ -114,8 +113,6 @@ cd securedrop-client
poetry install
```

* You may also want to run `make hooks`, which will configure Git to use the hooks found in `.githooks/` to check certain code-quality standards on new commits in this repository. These checks are also enforced in CI.

4. Run SecureDrop Client

```
Expand Down Expand Up @@ -169,7 +166,6 @@ socat TCP4-LISTEN:8081,fork,reuseaddr TCP4:A.B.C.D:8081
cd securedrop-client
poetry install
```
* You may also want to run `make hooks`, which will configure Git to use the hooks found in `.githooks/` to check certain code-quality standards on new commits in this repository. These checks are also enforced in CI.

5. Run SecureDrop Client
```
Expand Down