Move remaining CircleCI jobs to GitHub Actions #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some places the `lint` target is just flake8 and in others it runs all linters. Adopt the latter definition to ensure that `make lint` runs all tools that don't run any code.
ci.yml's "component-lint" job runs `make lint` in all four components, and varies by Debian version (except proxy/bookworm). test.yml's "component" job runs `make test` in all components except client. The "client" job runs the test-functional, test-integration, and test-random targets and installs the extra dependencies needed (now in client/Makefile). test.yml also has "internationalization", which checks strings have been extracted and are reproducible. Some parts of GitHub's UI makes it inconvenient to have a ton of jobs in one file, so tests have been split out into their own for solely that reason. Dependencies that aren't needed were dropped as part of this (e.g. libnotify-bin, libmagic1, python3-dev, etc.). Same with the `export PYTHONPATH=$PYTHONPATH:.` pattern (the current directory is always on the Python path...).
leee
approved these changes
Feb 21, 2024
leee
pushed a commit
that referenced
this pull request
Feb 21, 2024
Move remaining CircleCI jobs to GitHub Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review, will need infra to do merge
Description
Standardize
make linttarget in componentsIn some places the
linttarget is just flake8 and in others it runsall linters. Adopt the latter definition to ensure that
make lintrunsall tools that don't run any code.
Move remaining CircleCI jobs to GitHub Actions
ci.yml's "component-lint" job runs
make lintin all four components,and varies by Debian version (except proxy/bookworm).
test.yml's "component" job runs
make testin all components exceptclient. The "client" job runs the test-functional, test-integration, and
test-random targets and installs the extra dependencies needed (now in
client/Makefile).
test.yml also has "internationalization", which checks strings have been
extracted and are reproducible.
Some parts of GitHub's UI makes it inconvenient to have a ton of jobs in
one file, so tests have been split out into their own for solely that
reason.
Dependencies that aren't needed were dropped as part of this (e.g.
libnotify-bin, libmagic1, python3-dev, etc.). Same with the
export PYTHONPATH=$PYTHONPATH:.pattern (the current directory is always onthe Python path...).
Test Plan