Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security bug regarding long lived threads #179

Merged
merged 2 commits into from
Nov 15, 2018

Conversation

redshiftzero
Copy link
Contributor

Fixes #178

@redshiftzero
Copy link
Contributor Author

So the way to test this is to follow the steps in #178 (adding a log line prior to the time.sleep in each thread). Then when you log out you should see:

2018-11-15 13:59:17,166 - root:146(run) INFO: still here with self.api: <sdclientapi.API object at 0x11136b390>
2018-11-15 13:59:17,238 - root:100(run) INFO: still here with self.api: <sdclientapi.API object at 0x11136b390>
[ --- user clicks log out here --- ]
2018-11-15 13:59:22,171 - root:146(run) INFO: still here with self.api: None
2018-11-15 13:59:22,239 - root:100(run) INFO: still here with self.api: None
2018-11-15 13:59:27,175 - root:146(run) INFO: still here with self.api: None

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went though the test plan in qubes and works as expected, thanks @redshiftzero . Invalidating tokens server-side is tracked as part of freedomofpress/securedrop#3933

@redshiftzero redshiftzero merged commit 88ff31c into master Nov 15, 2018
@redshiftzero redshiftzero deleted the fix-security-bug-long-lived-threads branch November 15, 2018 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants