Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve login validation input #169

Merged
merged 2 commits into from
Nov 14, 2018
Merged

improve login validation input #169

merged 2 commits into from
Nov 14, 2018

Conversation

redshiftzero
Copy link
Contributor

This prevents sending invalid passwords/usernames to the server (these same checks done client-side in this PR you can see in models.py in the SecureDrop server repo)

Closes #133

Copy link
Contributor

@joshuathayer joshuathayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Only a minor nit- I might move the "constant" declarations to the top of the module (and use ALL_CAPS, which seems to be idiomatic for this sort of thing).

@heartsucker
Copy link
Contributor

If they were to be moved, they should be moved to be class variables, but also SCREAMING_SNAKE_CASE as they call it. However, this is fine. Letting @redshiftzero decide to merge or not.

@redshiftzero
Copy link
Contributor Author

word - will make this change and then merge!

@redshiftzero
Copy link
Contributor Author

thanks @heartsucker and @joshuathayer! Made the suggested change

@redshiftzero redshiftzero merged commit d7d6f01 into master Nov 14, 2018
@redshiftzero redshiftzero deleted the validation-logindialog branch November 14, 2018 19:01
legoktm pushed a commit that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants