-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge export, log and proxy repositories #1675
Conversation
logging audit
Ensures changes to a file opened in a dvm are not copied back to the calling vm
Update mimeapps for securedrop-export, securedrop-export 0.2.2
Update description in README to mirror current implementation
securedrop-export 0.2.3
Now we are using the incoming timeout value from the JSON input.
Increase the default Requests connection and read timeout from ten to 120 seconds.
Increase the proxy's default timeout
securedrop-proxy 0.2.1
Addresses CVE-2020-1747
Use the wheel hosted on pip mirror
Update PyYAML to 5.3.1
Uses incoming timeout value from JSON
securedrop-proxy 0.3.0
To have latest black, we need updated typed-ast, for that we have to upgrade mypy too, and for mypy upgrade to work, we had to upgrade the mypy-extensions. It first runs isort to check if it passes, and then it runs black. Both uses 100 as line length. setup.py marks Python version as >= 3.7 as we are testing and running the code only on 3.7 on Debian Buster. Also contains the formatting change in proxy.py for black check to run sucessfully on CI.
It adds a configuration file to skip the previous commmit which has isort and black formatting changes. ``` git config blame.ignoreRevsFile .git-blame-ignore-revs ```` After one executes the above command, `git blame` does not show details for the formatting commit.
…_dev Fixes #57 runs black & isor for code formatting check
Add the fixture for test_json_response_with_timeout
This prevents misidentification of Whonix VMs, which always use 'host' as the hostname.
- updated urllib3 from 1.25.8 to 1.25.10 - updated pip-tools to >=5.0.0 to clear pip-related error - Updated Makefile to pin pip and setuptools in dev requirements
Updated dependencies to clear safety checks
Bump certifi dev dependency due to removal of root certificate
We're still using redis==3.3.11, so we should be pulling in those type stubs and not the ones for v4. Coincidentally, those stubs also happen to not have dependencies on cryptography and types-pyOpenSSL, which is very nice. Refs <GHSA-jm77-qphf-c4w8>.
Use types-redis<4, drop cryptography and other dev dependencies
We're installing the Poetry system package on Debian Bookworm -- that's generally a preferable strategy going forward, and in fact, pip will error out if you attempt to install it from PyPI. This necessitates some conditional logic we can drop once we move fully to Bookworm.
Use Poetry for dependency management
Switch dependency management to use poetry, which is much nicer than pip-tools. This is largely based off of <freedomofpress/securedrop-proxy#122> and applies the same changes to the Makefile and CI.
Switch dependency management to use poetry, which is much nicer than pip-tools. This is largely based off of <freedomofpress/securedrop-proxy#122> and applies the same changes to the Makefile and CI.
Migrate dependency management to poetry
Migrate dependency management to poetry
This is a very naive complete merge by prefixing anchors and job names with component names. De-duplication and consolidation will happen in future commits.
CI failures for proxy on bookworm are expected, the one that isn't is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, individual packages can be built via PKG_PATH=<clientsrcpath>/<whatever> make securedrop-<whatever>
, so 👍 from me on the merge! Versioning unification and build logic can follow after.
The language is roughly taken from the client README.
Description
This begins implementing the SecureDrop Workstation component monorepo, as discussed in https://github.com/freedomofpress/securedrop-engineering/pull/32.
Test Plan
Post-merge tasks