Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make verify-mo.py compatible with securedrop #1668

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

cfm
Copy link
Member

@cfm cfm commented Sep 28, 2023

Description

freedomofpress/securedrop has stricter linting (ruff) and older typing (Python 3.8) than I tested with in #1666. This makes verify-mo.py compatible with both, after freedomofpress/securedrop#6953.

Test Plan

CI passes.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration is self-contained and applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

@cfm cfm requested a review from nathandyer September 28, 2023 02:30
@cfm cfm marked this pull request as ready for review September 28, 2023 02:30
@cfm cfm requested a review from a team as a code owner September 28, 2023 02:30
Copy link

@nathandyer nathandyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I had just a small question to make sure we're not accidentally leaving something out, but assuming that is intentional, this is good to go from my perspective.

scripts/verify-mo.py Show resolved Hide resolved
@cfm cfm merged commit 3afd720 into main Sep 28, 2023
@cfm cfm deleted the verify-mo-py3.8-compat branch September 28, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants