Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings, comparing int and float values #1511

Merged

Conversation

gonzalo-bulnes
Copy link
Contributor

@gonzalo-bulnes gonzalo-bulnes commented Jun 7, 2022

Description

Fixes #1509
Useful for #1496

Test Plan

  • Run the main test suite under Python 3.7 (make test), confirm that deprecation warnings are absent
  • Run the test suite under Python 3.9 (make test), confirm that deprecation warnings are present. You probably want to run it from the branch update-dev-deps-to-match-bullseye-env to get the new dependency versions, suited to Python 3.9.
  • Check this branch out, run the test suite under Python 3.7 (make test), confirm that it is all green
  • Check this branch out, run the test suite under Python 3.9 (make test), confirm that it is all green, no deprecation warnings

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Run the main test suite under Python 3.7 (make test), confirm that deprecation warnings are absent
  • Run the test suite under Python 3.9 (make test), confirm that deprecation warnings are present. You probably want to run it from the branch update-dev-deps-to-match-bullseye-env to get the new dependency versions, suited to Python 3.9.
  • Check this branch out, run the test suite under Python 3.7 (make test), confirm that it is all green
  • Check this branch out, run the test suite under Python 3.9 (make test), confirm that it is all green, no deprecation warnings

@sssoleileraaa sssoleileraaa merged commit 6b88692 into main Jun 8, 2022
@sssoleileraaa sssoleileraaa deleted the fix-deprecation-warnings-comparing-int-to-float branch June 8, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python deprecation warnings, comparing int to float
2 participants