Refactor move DeleteSourceDialog to 'gui.source' namespace #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@creviera This PR is extremely similar to #1393 - and it's ready to review 🙂 |
sssoleileraaa
approved these changes
Jan 25, 2022
| along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| """ | ||
| # Import classes here to make possible to import them from securedrop_client.gui.source.delete | ||
| from securedrop_client.gui.source.delete.dialog import DeleteSourceDialog # noqa: F401 |
There was a problem hiding this comment.
Okay, so you are hiding the dialog module from the path so that you can from securedrop_client.gui.source.delete import DeleteSourceDialog when you actually need to import DeleteSourceDialog vs from securedrop_client.gui.source.delete.dialog import DeleteSourceDialog. Either way works for me, but I tend to try to keep my __init__.py empty and kind of prefer the simplicity and explicit-y when importing classes, functions, and variables from somewhere.
sssoleileraaa
deleted the
refactor-move-source-deletion-dialog-to-namespace
branch
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🔮 Review recommendations: I split the changes in two commits, so that tests can be run (unchanged) after the class as been moved, then can be run again (without changes to the non-test code) after they are moved. 🙂
This is the 11th step to be split out of #1369.
It moves the
DeleteSourceDialogdefinition to its own file/module.Test Plan
DeleteSourceDialogdialog behavior and appearance hasn't changedDeleteSourceDialogdefinition is not changedDeleteSourceDialogunit tests haven't changedChecklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
If these changes modify the database schema, you should include a database migration. Please check as applicable:
mainand confirmed that the migration applies cleanlymainand would like the reviewer to do so