-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bug, feature, release templates #1392
Conversation
## How will this impact [SecureDrop users](https://github.com/freedomofpress/securedrop-ux/wiki/Users)? | ||
<!-- How do you feel this change might impact SecureDrop's usability, accessibility, or usefulness—and specifically, for which users? Has anecdotal feedback from users influenced this change? Does evidence exist from user research to support this idea? Could design or user research efforts be helpful to support a change? --> | ||
|
||
## How would this affect SecureDrop's [threat model](https://docs.securedrop.org/en/stable/threat_model/threat_model.html)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also link to https://github.com/freedomofpress/securedrop-workstation/#threat-model here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's link to the securedrop workstation threat model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding multiple links in these templates can get a bit unwieldy, so instead I've opened a separate docs PR to make the SDW threat model a bit more discoverable:
freedomofpress/securedrop-docs#302
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#302 has been merged. I still think it makes more sense for a developer to be directed directly to the SDW threat model, because if you follow the https://docs.securedrop.org/en/stable/threat_model/threat_model.html link, you'll have to read about the old SVS and other pieces that are different in the new architecture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, switched the links - that one also links back to the SD server/classical architecture threat model, in any event.
7c995b9
to
242c129
Compare
## How will this impact [SecureDrop users](https://github.com/freedomofpress/securedrop-ux/wiki/Users)? | ||
<!-- How do you feel this change might impact SecureDrop's usability, accessibility, or usefulness—and specifically, for which users? Has anecdotal feedback from users influenced this change? Does evidence exist from user research to support this idea? Could design or user research efforts be helpful to support a change? --> | ||
|
||
## How would this affect SecureDrop's [threat model](https://docs.securedrop.org/en/stable/threat_model/threat_model.html)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's link to the securedrop workstation threat model
All three templates read well, and are looking very good IMHO 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good to me! thanks :)
Adds bug and issue templates with language largely taken from the SecureDrop server repo. I've incorporated @ninavizz's proposed changes in freedomofpress/securedrop#6175 with some modifications; if you review this PR, please also review Nina's, so we can keep language in sync between the two.
The release template is new. It should resemble previous release tickets like #1275, with two notable differences:
This assumes that we'll want to continue to do most QA using nightlies (which does have the benefit of high developer agility -- we can build those quickly and on-demand without worrying about RC increments) while getting important pre-release confidence in our build results. Happy to describe a different process, e.g., if we want to instead use the release branch/RC builds model for the next release.