Refactor move ModalDialog to 'gui.base' namespace #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class neds to be extracted from widgets.py before any modal dialog can be.
sssoleileraaa
force-pushed
the
refactor-move-base-dialog-to-namespace
branch
from
eb64b12 to
13af3c2
Compare
There was a problem hiding this comment.
Test Plan
- Confirm that the dialogs behavior and appearance haven't changed (e.g.
LoginDialog,DeleteSourceDialog...) - Confirm that the
ModalDialogdefinition is not significantly changes (except for having an extra stylesheet of its own) - Confirm that the
ModalDialogunit tests haven't changed - Confirm that the translatable strings haven't changed
- Confirm that CI is green
|
Also, thank you for the review recommendations comment :) |
sssoleileraaa
approved these changes
Jan 12, 2022
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🔮 Review recommendations: I split the changes in three commits, it may be easier to review them one by one 🙂
This is the 8th step to be split out of #1369.
It moves the
ModalDialogdefinition to its own file/module.Test Plan
LoginDialog,DeleteSourceDialog...)ModalDialogdefinition is not significantly changes (except for having an extra stylesheet of its own)ModalDialogunit tests haven't changedChecklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
If these changes modify the database schema, you should include a database migration. Please check as applicable:
mainand confirmed that the migration applies cleanlymainand would like the reviewer to do so