provides tooling for interactive localization updates (option A) #1347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1317 by:
l10n
GitHub Actions workflow added in mechanizes continuous-localization workflow #1282;extract-strings
andcheck-strings
for clarity;check-strings
in CI to "lint" that the translation catalog has been updated viaextract-strings
; andcheck-strings
configurable withmake hooks
.How to think about this pull request
The following gist offers background considerations shared with, and for evaluating this "option A" pull request against, "option B" #1348:
https://gist.github.com/cfm/d3173206f55d7e44152928fcfd215031
Test Plan
_()
-wrapped source string and commit it1347-cfm-testing
(wherecfm
is your GitHub username ;-)test-buster
fails onmake check-strings
with the following error message:make hooks
(or rerunmake venv
or your platform-appropriate variant)git commit --amend
and confirm that the pre-commit hook fails onmake check-strings
as abovemake extract-strings
git commit --amend
and confirm that the commit succeedsgit push -f
to your testing branchtest-buster
passesChecklist
(option A)
from title and close provides tooling for interactive localization updates #1348 without mergingIf these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
If these changes modify the database schema, you should include a database migration. Please check as applicable:
main
and confirmed that the migration applies cleanlymain
and would like the reviewer to do so