Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provides tooling for interactive localization updates (option A) #1347

Closed
wants to merge 7 commits into from

Conversation

cfm
Copy link
Member

@cfm cfm commented Nov 23, 2021

Description

Closes #1317 by:

  1. removing the l10n GitHub Actions workflow added in mechanizes continuous-localization workflow #1282;
  2. renaming the Make targets extract-strings and check-strings for clarity;
  3. using check-strings in CI to "lint" that the translation catalog has been updated via extract-strings; and
  4. offering a Git pre-commit hook for check-strings configurable with make hooks.

How to think about this pull request

The following gist offers background considerations shared with, and for evaluating this "option A" pull request against, "option B" #1348:

https://gist.github.com/cfm/d3173206f55d7e44152928fcfd215031

Test Plan

  1. Change a _()-wrapped source string and commit it
  2. Push to testing branch like 1347-cfm-testing (where cfm is your GitHub username ;-)
  3. Confirm that test-buster fails on make check-strings with the following error message:

    Translation catalog is out of date. Please run "make extract-strings" and commit the changes.

  4. Run make hooks (or rerun make venv or your platform-appropriate variant)
  5. Try to git commit --amend and confirm that the pre-commit hook fails on make check-strings as above
  6. Run make extract-strings
  7. Retry git commit --amend and confirm that the commit succeeds
  8. git push -f to your testing branch
  9. Confirm that test-buster passes

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

@cfm
Copy link
Member Author

cfm commented Nov 30, 2021

Closing in favor of #1348 per #1317 (comment).

@cfm cfm closed this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rework localization Make targets for PR-level use
1 participant