Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoids kicking off translation updates at development runtime #1323

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

cfm
Copy link
Member

@cfm cfm commented Oct 25, 2021

Description

Fixes #1322 by removing the invocation of the compile-translation-catalogs Make target that makes loadable .mo files available to the Client at development runtime (run.sh).

As a side effect, no .mo files will be compiled at runtime, and the Client will fall back to the English source strings as if untranslated, regardless of locale, until a revised version of this translation worfklow is restored in #1317.

Test Plan

  1. Follow the steps to reproduce in local string changes yield noisy local changes to message catalogs #1322.
  2. Confirm that git status lists no .po[t] files with changes not staged for commit.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

As a side effect, no .mo files will be compiled at runtime, and the
Client will fall back to the English source strings as if untranslated,
regardless of locale, until a revised version of this translation
worfklow is restored in #1317.
@cfm cfm requested a review from a team as a code owner October 25, 2021 17:54
Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sssoleileraaa sssoleileraaa merged commit b1e8e0b into main Oct 25, 2021
@sssoleileraaa sssoleileraaa deleted the 1322-no-dev-translation-updates branch October 25, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local string changes yield noisy local changes to message catalogs
2 participants