enforces translation of GUI strings #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfm
force-pushed
the
1265-string-review
branch
2 times, most recently
from
f51fc31 to
cc1e640
Compare
rmol
suggested changes
Aug 3, 2021
sssoleileraaa
previously approved these changes
Aug 3, 2021
Catches Q{Action,Label,PushButton} constructors plus common Qt and
custom methods whose string arguments should be translated for
rendering in the GUI.
In these cases, the formatting arguments are string constants that are already marked for gettext.
cfm
force-pushed
the
1265-string-review
branch
3 times, most recently
from
8f4e1bc to
465f330
Compare
Catches strings of the form---
_("{foo} is a bar".format(foo=bar))
---that should take the form---
_("{foo} is a bar").format(foo=bar)
---unless foo itself is expected to be translated.
|
|
rmol
approved these changes
Aug 5, 2021
|
looks like the only ci failure is due to a known safety issue:
forcing merge based on @rmol's approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review
Description
Closes #1265 by:
untranslated-gui-stringto catch common cases of GUI strings not marked with gettext's_()wrapper; andTest Plan
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)These changes should not need testing in QubesIf these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
I have updated the AppArmor profileI don't know and would appreciate guidanceIf these changes modify the database schema, you should include a database migration. Please check as applicable:
I have written a migration and upgraded a test database based onmainand confirmed that the migration applies cleanlyI have written a migration but have not upgraded a test database based onmainand would like the reviewer to do soI need help writing a database migration