improve readability of test targets #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
force-pushed
the
refactor-test
branch
from
a0c97e2 to
cacb23d
Compare
Signed-off-by: Allie Crevier <[email protected]>
|
rebased on latest |
emkll
approved these changes
Apr 30, 2021
| @@ -67,24 +67,25 @@ clean: ## Clean the workspace of generated resources | |||
| TESTS ?= tests | |||
| ITESTS ?= tests/integration | |||
| FTESTS ?= tests/functional | |||
| TESTOPTS ?= -v | |||
| TESTOPTS ?= -v --cov-config .coveragerc --cov-report html --cov-report term-missing --cov=securedrop_client --cov-fail-under 100 | |||
There was a problem hiding this comment.
is the -v here apply to the same pytest command as the v on L74 and L81?
| @@ -116,7 +117,7 @@ bandit: ## Run bandit with medium level excluding test-related folders | |||
| bandit -ll --recursive . --exclude ./tests,./.venv | |||
|
|
|||
| .PHONY: check | |||
| check: clean check-black check-isort bandit lint mypy test-random test-integration test-functional ## Run the full CI test suite | |||
| check: clean check-black check-isort semgrep bandit lint mypy test-random test-integration test-functional ## Run the full CI test suite | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
TESTOPTSto improve readability.Run semgrep in
make testandmake test-randomwhich means we run semgrep in CI.Test Plan
make testandmake test-randomstill work