Updates PyYAML to 5.4.1, fix safety Makefile target, Run CI jobs nightly #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The requirements files were not discovered by the find command because it was searching for a filename, not a path.
Addresses CVE-2020-14343.
Initially suggested by @creviera in freedomofpress/securedrop-builder#219 (comment), let's add a nightly CI run to show CI failures in GitHub.
kushaldas
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
I kept rerunning the tests till CI passes :) Magic.
- CI is passing (tests should provide sufficient coverage here)
- Update to
safetymakefile target makes sense (see that CI is failing successfully in https://circleci.com/gh/freedomofpress/securedrop-client/5086) - Hashes for the dependencies are valid (this is a dev-only dependency, but @kushaldas has done a diff review in https://github.com/freedomofpress/securedrop-debian-packaging/wiki/PyYAML-5.3.1-to-5.4.1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Towards freedomofpress/securedrop-builder#219
Test Plan
safetymakefile target makes sense (see that CI is failing successfully in https://circleci.com/gh/freedomofpress/securedrop-client/5086)Checklist
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:
If these changes modify the database schema, you should include a database migration. Please check as applicable:
mainand confirmed that the migration applies cleanlymainand would like the reviewer to do so