Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set is_authenticated first on login success #1199

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented Dec 10, 2020

Description

Fixes issue reported during QA by @eloquence:

However, note that when going online, I have to wait until the next sync for the change to be correct again.

STR

Log into the client

Expected

For the client to immediately display sources as seen/unseen according to what's in the local db

Actual

The client displays the sources as all seen until the first sync completes

(Also test by starting off in offline mode then switching to online mode. And test once more by logging out and logging back in - do not close the client.)

Test Plan

Test the the STRs above are now seeing the expected state.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

@sssoleileraaa sssoleileraaa mentioned this pull request Dec 10, 2020
22 tasks
@sssoleileraaa sssoleileraaa force-pushed the client-0.4.0-qa-bug-fix-2 branch from f7c583b to 3227fb5 Compare December 10, 2020 03:59
@sssoleileraaa sssoleileraaa marked this pull request as ready for review December 10, 2020 03:59
@emkll emkll self-assigned this Dec 10, 2020
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unread messages are displayed as unread before the first sync completes

@emkll emkll merged commit e662cc3 into main Dec 10, 2020
@emkll emkll deleted the client-0.4.0-qa-bug-fix-2 branch December 10, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants