Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only maximize if window not already displayed #1192

Merged
merged 1 commit into from
Nov 27, 2020
Merged

only maximize if window not already displayed #1192

merged 1 commit into from
Nov 27, 2020

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented Nov 20, 2020 •
edited by emkll
Loading

Description

Fixes issue with maximizing the window when switching between offline and online mode.

Test Plan

  1. start the client in offline mode and change the main window size
  • verify that the window is maximized
  1. sign in from the user auth menu
  • verify that the window size does not change upon sign-in
  1. sign out form the user auth mentu
  • verify that the window size does not change upon sign-in
  1. close the client and log in
  • verify that the window is maximized

Checklist

This needs to be tested in Qubes.

@emkll emkll self-assigned this Nov 27, 2020
emkll
emkll approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan is passing in sd-app in Qubes, lgtm!

@emkll emkll merged commit a70da1b into main Nov 27, 2020
@emkll emkll deleted the keep-window-size-the-same branch November 27, 2020 21:36
@sssoleileraaa sssoleileraaa mentioned this pull request Dec 8, 2020
Closed
14 tasks
@eloquence eloquence mentioned this pull request Dec 8, 2020
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emkll emkll emkll approved these changes

@kushaldas kushaldas Awaiting requested review from kushaldas

@redshiftzero redshiftzero Awaiting requested review from redshiftzero

Assignees

@emkll emkll

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sssoleileraaa @emkll