update test docs #1144
Merged
update test docs #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sssoleileraaa
requested review from
kushaldas and
redshiftzero
as code owners
emkll
suggested changes
Sep 3, 2020
README.md
Outdated
| 1. Bypass TOTP verification so that we can use the TOTP value of `123456` hard-coded in `tests/conftest.py`. You can do this by applying the following diff to the server code: | ||
|
|
||
| ```diff | ||
| diff --git a/securedrop/models.py b/securedrop/models.py |
There was a problem hiding this comment.
this diff doesn't apply cleanly for me, with the error:
error: corrupt patch at line 13
The following diff did work for me, but looking at the previous revision, the following did appear to work for me.:
user@dev:~/src/securedrop$ git diff
diff --git a/securedrop/models.py b/securedrop/models.py
index ad991e6c3..1c954b9a6 100644
--- a/securedrop/models.py
+++ b/securedrop/models.py
@@ -658,6 +658,7 @@ class Journalist(db.Model):
try:
user = Journalist.query.filter_by(username=username).one()
+ return user
except NoResultFound:
raise InvalidUsernameException(
"invalid username '{}'".format(username))
There was a problem hiding this comment.
nice catch. i also added a gist with the patch to make it easier to download and apply.
sssoleileraaa
force-pushed
the
update-readme
branch
from
b53d9ec to
baac1a9
Compare
emkll
approved these changes
Sep 3, 2020
|
|
||
| 1. Bypass TOTP verification so that we can use the TOTP value of `123456` hard-coded in `tests/conftest.py`. You can do this by applying the following patch to the server code: | ||
|
|
||
| https://gist.github.com/creviera/8793d5ec4d28f034f2c1e8320a93866a |
There was a problem hiding this comment.
This is a good idea, definitely more readable and easier to review/use, provided the author does not delete it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove reference to old TOTP code and update README around functional testing.