-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear clipboard after login screen #1071
Conversation
Not on the sprint, but I feel we may want to land a version of this alongside freedomofpress/securedrop-workstation#533, to put some guardrails around the |
@@ -432,6 +434,9 @@ def login_offline_mode(self): | |||
Allow user to view in offline mode without authentication. | |||
""" | |||
self.gui.hide_login() | |||
# Clear clipboard contents in case of previously pasted creds (user | |||
# may have attempted online mode login, then switched to offline) | |||
self.gui.clear_clipboard() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The duplication here is intentional; I felt that this behavior should not be a side effect of another function, but explicitly invoked so the intended business logic is clear.
Added test plan & tests; will take a quick spin in Qubes now, as well. |
Tested both scenarios successfully in Qubes, including w/ cross-VM copying. |
8ab83da
to
58b8db4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM, thanks for preparing it. Ran through the testing in Qubes and all works as advertised.
Description
Fixes #1051 by clearing the system clipboard contents after logging into online or offline mode.
Status
Ready for review
Test plan (online mode)
Test plan (online mode)
Checklist