Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: disable context menu on SpeechBubble #1065

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Conversation

redshiftzero
Copy link
Contributor

Description

Fixes #1064 (removing context menu for now)

Test Plan

  • Ensure context menu does not appear for replies
  • Ensure context menu does not appear for messages
  • Ensure you can copy/paste text out of replies
  • Ensure you can copy/paste text out of messages

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Ensure context menu does not appear for replies
  • Ensure context menu does not appear for messages
  • Ensure you can copy/paste text out of replies
  • Ensure you can copy/paste text out of messages

Works as suggested. Approved

Copy link
Contributor

@kushaldas kushaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, forgot to click "Approve"

@kushaldas kushaldas merged commit a4dd8df into master Apr 23, 2020
@kushaldas kushaldas deleted the disable-context-menu branch April 23, 2020 14:14
@redshiftzero redshiftzero mentioned this pull request May 7, 2020
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy/paste context menus are rendered incorrectly
2 participants