Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: make QLabel text selectable #1063

Merged
merged 2 commits into from
Apr 22, 2020
Merged

app: make QLabel text selectable #1063

merged 2 commits into from
Apr 22, 2020

Conversation

redshiftzero
Copy link
Contributor

@redshiftzero redshiftzero commented Apr 22, 2020

Description

Fixes #1052.

Previously when adding text selectability to QLabel/SecureQLabel the application crashed with a segfault. After investigation this was due to an upstream bug that is fixed in qt 5.12.x but not in qt 5.11.x which we are currently using. There is a workaround (22e1b34) to handle this case until we are on a more recent version of qt.

Test Plan

  • Ensure that you can copy text from a reply
  • Ensure that you can copy text from a message
  • Ensure that text is only selectable in one message or reply at a time

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

Copy link
Contributor

@sssoleileraaa sssoleileraaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable selecting and copying text in message/reply bubbles
2 participants