Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update metadata sync gif #1057

Merged
merged 2 commits into from
Apr 10, 2020
Merged

update metadata sync gif #1057

merged 2 commits into from
Apr 10, 2020

Conversation

sssoleileraaa
Copy link
Contributor

Description

Fixes #1053

This is very subtle, but since we're playing a forever loop animation and stopping it once the metadata sync is finished, the stopping of the animation can look a bit abrupt. I fixed this by using nina's single loop animation of the metadata sync as the stopping animation rather than what we've been using: a gif of a static image.

Test Plan

Test with a small number of sources to ensure that every 15 seconds you see an animation pulse. Test with a large number of sources to ensure that that long metadata syncs show a continuous sync animation.

@sssoleileraaa sssoleileraaa force-pushed the fix-1053 branch 3 times, most recently from 3bb943c to 6fe108a Compare April 9, 2020 23:19
@sssoleileraaa
Copy link
Contributor Author

sssoleileraaa commented Apr 10, 2020

Another thing to test is that the sync animation is continuous when the securedrop server cannot be reached and will stop once a sync succeeds

@eloquence
Copy link
Member

eloquence commented Apr 10, 2020

Tested only in Docker env for now. Does what it says on the tin:

  • Short syncs as short
  • Long syncs are long (tested by adding sleeps to sync-related endpoints to Docker env)
  • Failing syncs spin until connectivity is restored (tested by ^C-ing Docker env, restarting)

Normal sync (wait for it)

normal_sync

Loooong sync

loong_sync

Error state

error_sync

Copy link
Contributor

@redshiftzero redshiftzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff lgtm, thanks @creviera and thanks for functional testing @eloquence !

@redshiftzero redshiftzero merged commit 8aaabc5 into master Apr 10, 2020
@redshiftzero redshiftzero deleted the fix-1053 branch April 10, 2020 18:18
@redshiftzero redshiftzero mentioned this pull request May 7, 2020
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show sync animation during the entire sync
3 participants