rely on sdk default for most requests #1056
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increase the timeouts to rely on the sdk's default of 20 seconds for any requests that we agressively killed after 5 seconds until we gather more staging/prod data on how long each request takes, see #648. We also are continuing to discuss the value of increasing the timeout each time a job retries until it runs out of retries.
What the subprocess timeouts will be after #1055 and this PR are merged
get_sources
get_all_replies
get_all_submissions
reply_source
add_star
remove_star
delete_source
authenticate
logout
Test Plan
Make sure there are no regressions.
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable: