Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rely on sdk default for most requests #1056

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Conversation

sssoleileraaa
Copy link
Contributor

@sssoleileraaa sssoleileraaa commented Apr 9, 2020

Description

Increase the timeouts to rely on the sdk's default of 20 seconds for any requests that we agressively killed after 5 seconds until we gather more staging/prod data on how long each request takes, see #648. We also are continuing to discuss the value of increasing the timeout each time a job retries until it runs out of retries.

What the subprocess timeouts will be after #1055 and this PR are merged

Endpoint SDK subprocess timeout
get_sources 60
get_all_replies 60
get_all_submissions 60
reply_source 20
add_star 20
remove_star 20
delete_source 20
authenticate 60
logout 60

Test Plan

Make sure there are no regressions.

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

redshiftzero
redshiftzero previously approved these changes Apr 14, 2020
@redshiftzero redshiftzero merged commit 4197e11 into master Apr 14, 2020
@redshiftzero redshiftzero deleted the bump-up-5-sec-min branch April 14, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants