Fix star hover state #1003
Merged
Fix star hover state #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntoll
requested review from
sssoleileraaa,
kushaldas and
redshiftzero
as code owners
|
(Taking this for a quick spin.) |
|
👍 Works as advertised and improves current starring behavior. (Only tested in non-Qubes for now.) |
sssoleileraaa
force-pushed
the
star-trek
branch
from
9fc219f to
088729e
Compare
sssoleileraaa
previously approved these changes
Mar 25, 2020
| @@ -1351,7 +1351,7 @@ def eventFilter(self, obj, event): | |||
| t = event.type() | |||
| if t == QEvent.HoverEnter: | |||
| self.setIcon(load_icon('star_hover.svg')) | |||
| elif t == QEvent.HoverLeave: | |||
| elif t == QEvent.HoverLeave or t == QEvent.MouseButtonPress: | |||
|
just a thought for a future improvement: if the star is already checked, then don't show the hover state when you mouse over it, otherwise it looks like a star that is unchecked about to be checked (this is obviously better when qubes support showing different mouse cursors to indicate something is clickable) |
sssoleileraaa
force-pushed
the
star-trek
branch
from
088729e to
a003c06
Compare
sssoleileraaa
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #985
Towards #986
This PR fixes the above two issues to the extent that Erik has described the expected initial solution (todo: hover background).
Screenie here:
Test Plan
Eyeball Mk.1 👀
Checklist
If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:
If these changes add or remove files other than client code, packaging logic (e.g., the AppArmor profile) may need to be updated. Please check as applicable: